search

frankhale / toby

A YouTube player for the desktop
138 stars 18 forks source link

Suggested videos open externally #67

Closed frankhale closed 8 years ago

frankhale commented 8 years ago

Looks like YouTube made a change recently to their [API and] suggested videos that are shown at the end of a played video. If you clicked on one they used to open in the current player instance. Now they open in an external browser. I verified this using my old versions of Toby which I know it worked in and it now opens in external browser window. Looks like the change is on the YouTube API end and not a regression on my part.

frankhale commented 8 years ago

I already have a "new-window" handler which traps the URL before opening an external window so I think I can hijack the URL and then send the video ID to the player instead of opening a new window. The Electron browser window currently has Node integration turned off. I'm going probably use socket-io to communicate from the Node side of Electron to the browser window in order to communicate this.

frankhale commented 8 years ago

I've got this fixed now and am currently testing it.

frankhale commented 8 years ago

Fixed via 4f09ab11a77911df84ca7715b6fc4aff7e33712a