frankhart2018 / primistore

Locally hosted password management tool
MIT License
5 stars 11 forks source link

chore: Refactor routing in App component and introduce RouterProvider #128

Closed MinavKaria closed 4 months ago

MinavKaria commented 4 months ago

Description (Issue #127 )

Updated the react router dom to version 6 with createBrowserRouter

Motivation and Context

It is important to stay updated and version 6 makes the route creation very easy by just adding

Too add a page in route you have to just add a object with path and element , we can also make a layout, which can be added in further improvements, the basic simple structure to add a new page is given below which makes it easier to developer to add page, and have a dedicated file for showing and editing all the pages having it and making App.tsx clean

 {
          path: '/route/:id',
          element: <ElementNeeded/>
 },

Thus making it easier for the beginners to add a page route and made the routes proper for better SEO

How Has This Been Tested?

Checked every route before committing , Fortunately all the routes work properly as previous.

Screenshots (if appropriate):

No visual feature as such so will be need to run on local environment to check the changes

Types of changes

Checklist:

frankhart2018 commented 4 months ago

I will take a look at that today.

MinavKaria commented 4 months ago

@frankhart2018 Ok, I am a contributor from GSSOC, so pls tag it accordingly.

MinavKaria commented 4 months ago

@frankhart2018 Did you check ?

MinavKaria commented 4 months ago

@frankhart2018 Please mark it GSSOC and the level