frankhart2018 / primistore

Locally hosted password management tool
MIT License
5 stars 11 forks source link

image reduce 40%, of tsc file #132

Closed Arnab7456 closed 3 months ago

Arnab7456 commented 3 months ago
  1. Refactored Dockerfile to implement a multi-stage build, separating the build environment from the runtime environment.
  2. Ensured TypeScript compilation occurs in the build stage, reducing the final image size by excluding unnecessary development dependencies.
  3. Updated the Dockerfile to install only production dependencies in the final image.
frankhart2018 commented 3 months ago

Was the container tested?

Arnab7456 commented 3 months ago

Yes, the container was tested in the runtime environment. It runs as expected with only the necessary production dependencies included, resulting in a significantly reduced image size

frankhart2018 commented 3 months ago

Can you please post screenshots of the running app, after running the container.

Arnab7456 commented 3 months ago

ok, you can check docker ps command that shows container run on port 8000 Screenshot from 2024-08-19 00-41-26 Screenshot from 2024-08-19 00-41-35

frankhart2018 commented 3 months ago

Awesome, merging.