search

frankheckenbach / ftgl

fork from http://sourceforge.net/projects/ftgl
Other
24 stars 13 forks source link

Fix usage of AC_ARG_WITH #13

Closed ryandesign closed 3 years ago

ryandesign commented 3 years ago

Use AC_ARG_WITH correctly so that the advertised configure options actually exist under their expected names.

./configure --help claims that the following options exist:

  --with-gl-inc=DIR       Directory where GL/gl.h is installed
  --with-gl-lib=DIR       Directory where OpenGL libraries are installed
  --with-glu-lib=DIR      Directory where OpenGL GLU library is installed
  --with-glut-inc=DIR     Directory where GL/glut.h is installed (optional)
  --with-glut-lib=DIR     Directory where GLUT libraries are installed
                          (optional)

but they don't:

./configure --with-gl-inc=/tmp --with-gl-lib=/tmp --with-glu-lib=/tmp --with-glut-inc=/tmp --with-glut-lib=/tmp
Password:
configure: WARNING: unrecognized options: --with-gl-inc, --with-gl-lib, --with-glu-lib, --with-glut-inc, --with-glut-lib
^C

This is happening because AC_ARG_WITH is used incorrectly. In fact, as currently written, the configure script honors these unexpectedly named options:

This PR fixes the problem by calling AC_ARG_WITH correctly.

I am aware that you are no longer maintaining ftgl, but since this is still the latest upstream for ftgl that I am aware of, I am submitting this bug fix here.