search

frankie567 / httpx-oauth

Async OAuth client using HTTPX
https://frankie567.github.io/httpx-oauth/
MIT License
136 stars 45 forks source link

add code verifier (PKCE) + extra data from facebook and google (first name, last name and picture) #268

Closed stepan-chatalyan closed 2 years ago

stepan-chatalyan commented 2 years ago

tests pass and coverage 100%

sorry for bumping the version

frankie567 commented 2 years ago

Hi @stepan-chatalyan!

Thank you for your proposal! Unfortunately, this is quite hard for me to merge it like this.

  1. The PKCE support is interesting and it would be great if we could have a PR with only this single feature added
  2. Regarding the support of extra data from social providers, this is not something I want to support in the library. In my opinion, the OAuth2 client helps you get a valid access token to the auth provider. Once you have it, you can do anything you want to retrieve the data you need. Maintaining user data parsing for each providers is not an option for me.

I hope you'll understand my position. In the future, I invite you to open a Discussion before starting big chunks of work like this, to avoid any frustration 🙂