search

frankie567 / httpx-oauth

Async OAuth client using HTTPX
https://frankie567.github.io/httpx-oauth/
MIT License
136 stars 45 forks source link

add code verifier (PKCE) #270

Closed stepan-chatalyan closed 2 years ago

stepan-chatalyan commented 2 years ago

@frankie567 based on your comments from the previous PR.

Here is just the PKCE with 100% tests passing.

I also modified the make test to fail if coverage is under 100%

Cheers!

codecov[bot] commented 2 years ago

Codecov Report

Merging #270 (5df40d6) into master (1d9256e) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9        10    +1     
  Lines          250       271   +21     
=========================================
+ Hits           250       271   +21
Impacted Files Coverage Δ
httpx_oauth/integrations/fastapi.py 100.00% <100.00%> (ø)
httpx_oauth/oauth2.py 100.00% <100.00%> (ø)
httpx_oauth/clients/okta.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d9256e...5df40d6. Read the comment docs.

frankie567 commented 2 years ago

Sounds good! Thank you for this @stepan-chatalyan 🙏