frankie567 / httpx-oauth

Async OAuth client using HTTPX
https://frankie567.github.io/httpx-oauth/
MIT License
140 stars 48 forks source link

Added Discord provider + tests #274

Closed williamhatcher closed 2 years ago

williamhatcher commented 2 years ago

Fixes #273

I also tested this with a real implementation to make sure it works.

codecov[bot] commented 2 years ago

Codecov Report

Merging #274 (7980c5a) into master (b06a320) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #274   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        12    +1     
  Lines          321       345   +24     
=========================================
+ Hits           321       345   +24     
Impacted Files Coverage Δ
httpx_oauth/clients/discord.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b06a320...7980c5a. Read the comment docs.

frankie567 commented 2 years ago

Hello @williamhatcher 👋

Thank you for this contribution, very interesting! Looks good!

May I ask you to add it to the docs, following the same model as the others, e.g:

https://github.com/frankie567/httpx-oauth/blob/b06a32050c8a1dbb409d9d4b956fe1120879df1d/docs/oauth2.md?plain=1#L165-L174

williamhatcher commented 2 years ago

Sure, I’ll handle that tomorrow, time permitting.

Want me to take a crack at #229 ? I’ve never used Shopify, but I can take a look.

Do you have guidelines on what providers you want added?

frankie567 commented 2 years ago

Thanks!

Well, to be honest, unless you really want to add Shopify because you need it, it's not a super necessary addition, IMO.

williamhatcher commented 2 years ago

@frankie567 I added Discord to the docs like you asked, and noted that I contributed the Discord class. If you'd rather not have the contributor name in the docs, then I'm happy to remove it.

frankie567 commented 2 years ago

Looks good! Thank you @williamhatcher 👍