search

frankie567 / httpx-oauth

Async OAuth client using HTTPX
https://frankie567.github.io/httpx-oauth/
MIT License
140 stars 48 forks source link

Add OAuth 2.0 client for NAVER #289

Closed joonas-yoon closed 2 years ago

joonas-yoon commented 2 years ago

created new client for NAVER.

for information, NAVER is a one of famous web service for search in South Korea.

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (ea4420e) compared to base (28d0906). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #289 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 17 +2 Lines 379 437 +58 ========================================= + Hits 379 437 +58 ``` | [Impacted Files](https://codecov.io/gh/frankie567/httpx-oauth/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron) | Coverage Δ | | |---|---|---| | [httpx\_oauth/clients/naver.py](https://codecov.io/gh/frankie567/httpx-oauth/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron#diff-aHR0cHhfb2F1dGgvY2xpZW50cy9uYXZlci5weQ==) | `100.00% <100.00%> (ø)` | | | [httpx\_oauth/clients/kakao.py](https://codecov.io/gh/frankie567/httpx-oauth/pull/289/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron#diff-aHR0cHhfb2F1dGgvY2xpZW50cy9rYWthby5weQ==) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

frankie567 commented 2 years ago

Looks good! I see that BASE_SCOPE is empty, is it normal? No scope are required to access the API?

joonas-yoon commented 2 years ago

Looks good! I see that BASE_SCOPE is empty, is it normal? No scope are required to access the API?

Yes it's right what you see. According to official API documentation, there is no scope to get an access token.

joonas-yoon commented 2 years ago

got 100% coverage! and fixed typo on test class name

frankie567 commented 2 years ago

Looks good, thanks! Happy to have Korean services available 😄🇰🇷