frankie567 / httpx-oauth

Async OAuth client using HTTPX
https://frankie567.github.io/httpx-oauth/
MIT License
136 stars 45 forks source link

Fix argument name typo in Google client #299

Closed Gr3atWh173 closed 1 year ago

Gr3atWh173 commented 1 year ago

Fixed a small typo in the Google OAuth client. Might be a breaking change for other dependents like Fief.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (061303b) compared to base (846f96e). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #299 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 16 17 +1 Lines 436 437 +1 ========================================= + Hits 436 437 +1 ``` | [Impacted Files](https://codecov.io/gh/frankie567/httpx-oauth/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron) | Coverage Δ | | |---|---|---| | [httpx\_oauth/clients/google.py](https://codecov.io/gh/frankie567/httpx-oauth/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron#diff-aHR0cHhfb2F1dGgvY2xpZW50cy9nb29nbGUucHk=) | `100.00% <ø> (ø)` | | | [httpx\_oauth/\_\_init\_\_.py](https://codecov.io/gh/frankie567/httpx-oauth/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron#diff-aHR0cHhfb2F1dGgvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Fran%C3%A7ois+Voron)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

frankie567 commented 1 year ago

Hmm, good point, I never noticed it was singular on the Google client 😅

A priori, Fief shouldn't be impacted since it doesn't set the scope at class initialization.

However, for people out there using Google, that will probably be a breaking change!

frankie567 commented 1 year ago

Thank you for raising and fixing this 🙏 Will merge and release!

@all-contributors add @Gr3atWh173 for bug

allcontributors[bot] commented 1 year ago

@frankie567

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

I've put up a pull request to add @Gr3atWh173! :tada: