search

frankie567 / httpx-oauth

Async OAuth client using HTTPX
https://frankie567.github.io/httpx-oauth/
MIT License
136 stars 45 forks source link

Fix use Github primary email instead of first #318

Closed lloesche closed 5 months ago

lloesche commented 5 months ago

When no public email address is defined in the user's profile this PR uses the user's primary address instead of the first one found. If no primary is defined it (I don't think this could ever happen) it would fall back to the previous behaviour of using the first one.

Fixes #317

frankie567 commented 5 months ago

Good catch, that's indeed the right way to do! Thank you 🙏

frankie567 commented 5 months ago

@all-contributors add @lloesche for bug, code

allcontributors[bot] commented 5 months ago

@frankie567

I've put up a pull request to add @lloesche! :tada: