search

frankie567 / httpx-oauth

Async OAuth client using HTTPX
https://frankie567.github.io/httpx-oauth/
MIT License
136 stars 45 forks source link

Fix missing PKCE field #321

Closed king-jam closed 5 months ago

king-jam commented 5 months ago

PKCE support only had the code_verifier portion on the get_access_token method. While possible to use extras_params for this, PKCE is becoming more mainstream so making it a first class field.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (07f2e8a) 100.00% compared to head (1fba51e) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #321 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 18 18 Lines 486 490 +4 ========================================= + Hits 486 490 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frankie567 commented 5 months ago

Thank you @king-jam 🙏

@all-contributors add @king-jam for code

allcontributors[bot] commented 5 months ago

@frankie567

I've put up a pull request to add @king-jam! :tada: