search

frankie567 / httpx-ws

WebSocket support for HTTPX
https://frankie567.github.io/httpx-ws/
MIT License
110 stars 17 forks source link

Fixes `httpcore` import in `httpx_ws/_api.py` #36

Closed saforem2 closed 1 year ago

saforem2 commented 1 year ago

Fixes #35

frankie567 commented 1 year ago

Thank you @saforem2 for the fix!

So, it seems that we also need to do that here:

https://github.com/frankie567/httpx-ws/blob/f0e4d4b124d3ca7b0a85178f8294c22542841ce5/httpx_ws/transport.py#L8

I would also like to bump the dependency in pyproject.toml: httpcore>=0.17.3,<0.18 So we're sure everyone is on the same level + avoid future breaking changes.

saforem2 commented 1 year ago

should be good to go 🚀

saforem2 commented 1 year ago

ope, missed the import in tests/test_api.py

83bfdb3 should fix and resolve failing tests

frankie567 commented 1 year ago

Lol, this one was trickier than expected! Good to go, now. Thank you for your efforts 🙏

@all-contributors add @saforem2 for bug

allcontributors[bot] commented 1 year ago

@frankie567

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

I've put up a pull request to add @saforem2! :tada: