Closed kousikmitra closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
b48b070
) compared to base (644700b
). Patch coverage: 100.00% of modified lines in pull request are covered.:exclamation: Current head b48b070 differs from pull request most recent head ebaa5b8. Consider uploading reports for the commit ebaa5b8 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks good, @kousikmitra, thanks π May I ask you to add payload
as an optional parameter and forward it to the event initializer? Something like:
def ping(self, payload: typing.Optional[bytes] = None) -> None:
event = wsproto.events.Ping(payload)
self._send_event(event)
Looks good, @kousikmitra, thanks π May I ask you to add
payload
as an optional parameter and forward it to the event initializer? Something like:def ping(self, payload: typing.Optional[bytes] = None) -> None: event = wsproto.events.Ping(payload) self._send_event(event)
done, changed the func signature to ping(self, payload: bytes = b"")
as Ping doesn't take None
done, changed the func signature to
ping(self, payload: bytes = b"")
as Ping doesn't take None
Indeed, perfectly right! LGTM!
@all-contributors add @frankie567 for maintenance, @kousikmitra for code
@frankie567
I've put up a pull request to add @frankie567! :tada:
Yes, but now, @all-contributors add @kousikmitra for code
@frankie567
I've put up a pull request to add @kousikmitra! :tada:
fixed lint issue