search

frankier / skelshop

📺 📰 🧑‍💼 Toolkit for skeleton & face analysis of talking heads (e.g. news) videos 🧑‍💼 📰 📺
https://frankier.github.io/skelshop
MIT License
5 stars 1 forks source link

idrnnclus's min_weight_full_bipartite_matching throws uncaught ValueError #53

Closed cstenkamp closed 3 years ago

cstenkamp commented 3 years ago

Hi Frankie,

When I want to run skelshop iden idrnnclus .../ref.h5 .../model.rnndbscan.pkl .../rnndbscan.cluster.labels.csv, with the given files, SciPy's min_weight_full_bipartite_matching (@ https://github.com/frankier/skelshop/blob/master/skelshop/cmd/iden/idrnnclus.py#L54) throws me a ValueError " no full matching exists", which is uncaught and lets the skelshop fail. Can that simply be wrapped inside a try-catch-block, or is there any other way to resolve that?

rnndbscan_fail.zip

frankier commented 3 years ago

Whoops! Looks like I didn't test that with more than one reference! It seems to be fixed now so you can get the new version which has also just been rebuilt https://gitlab.com/frankier/skelshop/-/commit/a3f38ddbf450627f5f9b30d296753ebbc04cd920/pipelines?ref=master

frankier commented 3 years ago

BTW thanks for making it easy to replicate. Let me know if it fixed your problem so I can close this issue.

cstenkamp commented 3 years ago

Hey, thanks a lot for being so quick on this! So far however it seems like the container hasn't been rebuilt (https://hub.docker.com/r/frankierr/skelshop/builds)? Can you trigger the build manually? I don't think I can for your dockerhub account

frankier commented 3 years ago

It's building and I've invited you to the Docker Hub. Probably I should migrate to GitHub Actions since Docker Hub is so throttled now but I will ping you when it's built.

frankier commented 3 years ago

Although actually now I come to mention it, you don't necessarily need a totally new container in this case. I wrote a bit about speeding things up using this here: https://frankie.robertson.name/research/effective-cluster-computing/#use-binds

frankier commented 3 years ago

Okay looks like it's done now.

cstenkamp commented 3 years ago

oh wow, that took quite some time! Thanks though!

frankier commented 3 years ago

Yeah it's to do with Docker Hub's new throttling I think. Builds get stuck in the queue forever.

cstenkamp commented 3 years ago

seems to work, thanks a lot! :)