search

frankkramer-lab / MIScnn

A framework for Medical Image Segmentation with Convolutional Neural Networks and Deep Learning
GNU General Public License v3.0
398 stars 116 forks source link

Support latest Tensorflow/Keras #126

Closed innat closed 2 years ago

innat commented 2 years ago

Currently, it supports tf 2.7 only. But it can be used for tf >= 2.6.

innat commented 2 years ago

@muellerdo

muellerdo commented 2 years ago

Depending the setup.py vs requirements.py issue, I refer to the excellent comment of AndreasT in the StackOverflow post:

requirements.txt: This helps you to set up your development environment. ... setup.py: This helps you to create packages that you can redistribute.

Summarized, setup.py should be more dynamic like in your pull request and requirements.txt should be a momentum status or freeze.

Sources:

muellerdo commented 2 years ago

Switched base to dev branch, rerun CI jobs.

muellerdo commented 2 years ago

All checks are fine. Merging.

Thanks for the PR @innat ! :)