frankkramer-lab / MIScnn

A framework for Medical Image Segmentation with Convolutional Neural Networks and Deep Learning
GNU General Public License v3.0
402 stars 116 forks source link

"patchwise-crop" need a patch shape // channel notation inconsistencies #158

Open Pfleiderer-Adrian opened 2 years ago

Pfleiderer-Adrian commented 2 years ago

In processing/preprocessor.py it says on the patch_shape value documentation: "This parameter will be redundant if fullimage or patchwise-crop analysis is selected!!". But in the init-function, the patch-shape parameter check fires an error if the patch-shape is None or not specified when patchwise-crop is selected as analysis option.

The documentation says also that the subfunction use the patch-shape in first-channel mode but the MIScnn I/O Definition uses the last-channel notation. Maybe this sould be unified?