search

frankkramer-lab / MIScnn

A framework for Medical Image Segmentation with Convolutional Neural Networks and Deep Learning
GNU General Public License v3.0
402 stars 116 forks source link

img_shape not updateded in sample object #22

Open MLRadfys opened 4 years ago

MLRadfys commented 4 years ago

Hi Dominik,

I just noticed that the img_shape attribute is not updated in a sample object when for example using the resample subfunction. Is that on purposes in order to preserve information about the original dimension. Otherwise adding :

sample.shape = img_data.shape

to the preprocessing function should do the magic.

Cheers,

Michael

muellerdo commented 4 years ago

Hello Michael,

you are right. Thanks for pointing this out.

It was originally intended but, as far as I can see right now, it can and should be modified accordingly when using the resize or resample subfunction.

I will dig into it and add the shape update to the two subfunctions.

Cheers, Dominik

MLRadfys commented 4 years ago

Hi Dominik,

thanks! It does not affect the functionality though. I just stumbled about it while debugging my code :-)

Cheers,

Michael