frankkramer-lab / aucmedi

a framework for Automated Classification of Medical Images
https://frankkramer-lab.github.io/aucmedi/
GNU General Public License v3.0
38 stars 13 forks source link

Add flake8 linter and isort workflow to aucmedi #228

Open DanielHieber opened 1 month ago

DanielHieber commented 1 month ago

Adds flake8 and isort import linter to aucmedi workflows with custom config.

muellerdo commented 1 month ago

Really nice contribution, thank you very much for that awesome code quality improvement!

One thing: AUCMEDI officially supports the latest NumPy stable Python version -> 3.9 right now. You integrated matching syntax in the automl train/pred/eval scripts, which is not working for the 3.9 CI (Python 3.9 requirements run). Could you make that downwards compatible with also Python3.9?

We plan to integrate the PR after the dev branch is build stable again (probably next week as @rizoudal is fixing the last two bugs in #227 ).