franklhy / silc

Screen for InterLocked Chemistry
0 stars 0 forks source link

mistake in logger #12

Closed gervasiozaldivar closed 6 months ago

gervasiozaldivar commented 6 months ago

In silc/md/logger.py

    if self.counter > self.offset and self.counter % self.period_hist_force == 0:
        hist = state.hist
        if self.hist is None:
            self.hist = copy.copy(hist)
            self.hist_cum = copy.copy(hist)
        else:
            self.hist = hist - self.hist_cum
            **self.dhist_cum = copy.copy(hist)**
        self.save_file_hist()

seld.dhist_cum should be self.hist.cum, right?

franklhy commented 6 months ago

You are right. I created a PR that fixes the typo.