codepathreview
commented
8 years ago :+1: nice work. A few notes after checking out the code:
- Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
- Good use of string resources for text values
- Glad you thought about error handling for invalid or empty input cases
- Consider adding progress bars to your app whenever a network request goes out
- Properly reused the single base method in search activity to fetch results for both initial load and the pagination
- Nice to see you added the search box to the ActionBar!
- Properly used spinners (with populated values) to allow users to select filters
- Consider using bundle to pass dismiss information to SearchActivity. It is a bad practice to use parent activity in DialogFragment.
- One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a serializable model (i.e
SearchFilters.java) representing all the filters which were passed back and forth between activities within the bundle. - Nice job adding the share intent to the article detail view!
- Make sure to try out creating a date picker dialog.
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
franklinho
My app is complete. Please review. /cc @codepathreview @codepath