frankluebeck / GAPDoc

A package to generate documentation for GAP (https://www.gap-system.org) code
http://www.math.rwth-aachen.de/~Frank.Luebeck/GAPDoc/
5 stars 10 forks source link

Avoid InstallValue for non-plain objects #55

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

InstallValue is one of a tiny handful of places calling the GAP kernel function CLONE_OBJ. This function is rather dangerous, e.g. for types it is not really well-defined, see https://github.com/gap-system/gap/issues/1637. While I am not aware of any ill-effects of the usage here, I think it is best to avoid it (and perhaps we can at some point even phase out support for InstallValue used on non-plain objects)

frankluebeck commented 2 years ago

Thanks for the suggestion.