search

frankmullenger / silverstripe-gallery

Image gallery for SilverStripe 3
23 stars 17 forks source link

Statics in custom Page classes need to be "private" from 3.1.0 onwards #11

Closed svandragt closed 10 years ago

svandragt commented 10 years ago

When doing a /dev/build the code won't work on 3.1.0 onwards because the statics aren't private.

frankmullenger commented 10 years ago

@svandragt thanks for these improvements mate!

svandragt commented 10 years ago

Would you like me to continue working to decouple the gallery implementation from the SilverStripe integration? That way people could create extensions for your module and have it use theirs instead of FancyBox.

frankmullenger commented 10 years ago

@svandragt that would be great, thank you. Might be a good candidate for dependency injection.