search

frankmullenger / silverstripe-gallery

Image gallery for SilverStripe 3
23 stars 17 forks source link

Fixes for JS isues in SS3.1.2 #8

Closed thezenmonkey closed 10 years ago

frankmullenger commented 10 years ago

Thanks @thezenmonkey! Do you know if this is backwards compatible with SS 3.1.1 or earlier 3.1.0? Just thinking maybe we should create another branch for 3.1.2 and merge this pull request into that - thoughts?

thezenmonkey commented 10 years ago

I haven't had a chance to test it. But I did learn the JS fails when editing a page via model admin. Trying figure out the best way to refraction the urlSort lookup to make it generic.

Sent from my iPhone

On Nov 27, 2013, at 3:11 PM, Frank Mullenger notifications@github.com wrote:

Thanks @thezenmonkey! Do you know if this is backwards compatible with SS 3.1.1 or earlier 3.1.0? Just thinking maybe we should create another branch for 3.1.2 and merge this pull request into that - thoughts?

— Reply to this email directly or view it on GitHub.

frankmullenger commented 10 years ago

@thezenmonkey thanks again for this, can confirm that your patch works on 3.1.2. Instead of merging this pull request I've pulled your changes into the 1.1 branch and updated the composer requirements.