main.css issues - Githubissues

necolas commented 13 years ago

There are 2 body rulesets. Should be combined.
Remove tt element. It's obsolete in HTML5 "and must not be used by authors".
You've removed the border on fieldset, and overridden the default margins, but the default padding is still there. You might want to remove it.
Missing legend margin fix for IE6/7
Repetition of font and color styles used on body and form elements. Consider merging into one ruleset.
Missing IE6/7 overflow:visible fix for input and button
Missing Firefox ::-moz-inner-focus fix for input and button
The blockquote > p rulset doesn't seem to be needed
mark and ins have different semantics. Consider giving them different visual appearances
th doesn't need to have font-weight:bold specified. As far as I know, this is the default in all browsers
What is background:none used for on lines 248 and 251?

frankpf commented 13 years ago

Everything fixed, except the background: none. I did leave it there to remember people they can change it directly on the html instead of adding a wrapper (even though I added a link, I think many won't check it and will still use an wrapper). Do you think I should add a comment explaining this?

necolas commented 13 years ago

Yeah, I think removing the unnecessary CSS and including a comment about adding backgrounds to html would be a good idea.

frankpf commented 13 years ago

Done!

necolas commented 13 years ago

Noticed you're missing the zeroing out of margins on fieldset, and the inclusion of border:0 on legend to make it inherit color in IE

frankpf commented 13 years ago

Fieldset margins are already 'fixed' in this rule:

p, blockquote, q, pre, address, hr, code, samp, dl, ol, ul, form, table, fieldset, menu, h4, h5, h6, img, figure, figcaption, button, hr {
    margin: 0 0 1.625em;
}

border:0 on legend was fixed.

Thank you!

frankpf / gridless-boilerplate

main.css issues #4