frankvHoof93 / TikTokLiveSharp

Port of TikTok live library for C#
https://vanhoof.dev
Other
140 stars 28 forks source link

Non-streakable Gifts do not run their 'streak-end' event #11

Closed frankvHoof93 closed 8 months ago

frankvHoof93 commented 1 year ago

Some gifts seem to be non-streakable. These will never call their streak-end event.

frankvHoof93 commented 1 year ago

TODO: Find a way to identify these gifts, so they can default to their streak-end event upon the first message.

FilterUnfiltered commented 12 months ago

This works fine in the python version, doesn't it?

8qBITs commented 12 months ago

Was this fixed?

8qBITs commented 12 months ago

This works fine in the python version, doesn't it?

yes infact it does work with python library.

Farliam93 commented 11 months ago

Was this fixed?

if(e.Gift.Type == 1 && e.StreakFinished) { //Add Amount } else if(e.Gift.Type == 2) { //Add Amount } else if(e.Gift.Type == 4) { //Add Amount } else if(e.Gift.Type != 1){ //Unknown Type }

Only Type 1 have a Streak.

frankvHoof93 commented 11 months ago

@Farliam93 thanks.. Going to update this in the next version. Any idea what the other 'types' would be? (I'd rather implement an enum than keep it as a uint if possible)

frankvHoof93 commented 8 months ago

Resolved in v1.0.0