frankvogt / vcf2gwas

Python API for comprehensive GWAS analysis using GEMMA
GNU General Public License v3.0
84 stars 29 forks source link

Output results folders contain blank spaces #16

Open vinod1981 opened 2 years ago

vinod1981 commented 2 years ago

Dear Frank, In the new version of vcf2gwas, output folder specially Mixed Linear Model contains blank spaces which can't further be used as path without replacing those spaces. Please see the issue! Thanks,

Vinod

frankvogt commented 2 years ago

Hi Vinod, you can always escape the spaces with backslashes or by putting the complete path in quotation marks, but I'll change it back in the next version to not include spaces in the folder names. Best, Frank

vinod1981 commented 2 years ago

Dear Frank, Thank you very much for reply. I also found that '%' signs in best p-values folder bring issue when I want to extract something out of these files. I have to delete them manually and for 100s of analysis it is a bit time consuming. I feel it should be like previous version. Thanks, Vinod

krishna1925 commented 1 year ago

Hi, I had a issue while running vcf2gwas. It worked well in my previous analysis and now, it throws this error! Traceback (most recent call last): File "/home/kpa26/anaconda3/envs/myenv/lib/python3.9/site-packages/vcf2gwas/analysis.py", line 204, in raise_error(ValueError, msg, Log) File "/home/kpa26/anaconda3/envs/myenv/lib/python3.9/site-packages/vcf2gwas/utils.py", line 147, in raise_error raise error(msg) ValueError: No individuals left! Check if IDs in VCF and phenotype file are of the same format

I double checked all ids in the vcf file and phenotype file and they are exactly same. Could you please let me know how to solve this issue? Krishna

frankvogt commented 1 year ago

@vinod1981 From v0.8.8 onwards the output directories don't contain spaces anymore and the percent symbol is removed aswell.

@krishna1925 Could you update vcf2gwas (conda update vcf2gwas -c bioconda -c conda-forge -c fvogt257) and check if the issue remains?