cleanup based on undertaker init lifecycle

frankwallis / gulp-hub

Gulp plugin to run tasks in multiple gulpfiles

MIT License

88 stars 24 forks source link

cleanup based on undertaker init lifecycle #26

Closed phated closed 9 years ago

phated commented 9 years ago

I've done a bunch of cleanup related to the init lifecycle hook introduced into undertaker. Mostly, I switched usage of the DefaultRegistry to the ForwardReferenceRegistry and removed the dependency on because you have access to the instance inside the init method, where most of the logic for this module now exists within. I also updated the tests to reflect the init changes.

Ref #24

frankwallis commented 9 years ago

Thanks for this, it looks good. I'm going to merge it and then probably make a few tweaks.

Also FYI - as per https://github.com/frankwallis/gulp-hub/pull/27 when I publish this version to npm I am going to rename it to 'hub-registry' I think.