Extend disallowSkip option

frankyghost / projekktor

The Free Web Video Player

194 stars 75 forks source link

Extend disallowSkip option #44

Open mariusbuescher opened 10 years ago

mariusbuescher commented 10 years ago

This adds the direcitonal skip feature to the player.

mariusbuescher commented 10 years ago

Sorry for the duplicate. My bad.

rwlodkowski commented 10 years ago

@mariusbuescher thanks for that. I think it'll be nice addition to the projekktor functionality. One thing, please push only the relevant changes and remove all the whitespace changes you've done. Thank you.

rwlodkowski commented 10 years ago

And remove console.log :)

rwlodkowski commented 10 years ago

@mariusbuescher there is much more things to do to with that functionality.

Please add relevant changes to:

setActiveItem and setFrame functions in projekktor.js
updateDisplay and scrubberdragStartDragListener functions in projekktor.controlbar.js

You should also add comments in projekktor.config.js for that setting.

mariusbuescher commented 10 years ago

I don't think there is a need for implementing the functionality in scrubberdragStartDragListener because it calls a function where the check is done. Also you can only do it after the mouse event is called, so there is not such a big issue on performance here.