frankyonnetti / gravity-sublime-theme

A Sublime Text theme that feels right at home on macOS
https://frankyonnetti.github.io/gravity-sublime-theme/
396 stars 26 forks source link

Tabs. #34

Closed gobijan closed 9 years ago

gobijan commented 9 years ago

Hi Frank,

thx for releasing 2.5 of gravity. I like the font-size changes in the sidebar to 12px.

I am not so happy with the tabs in the top and liked the old tabs better. These are the problem spots IMHO:

The tabs feel not so predictable anymore. The default tabs also have margin to the top but they don't change the shape from full height to lower height all of a sudden when it gets selected.

Is there an option to get the "old" tabs back?

frankyonnetti commented 9 years ago

Hey @tschundeee Sorry to disappoint. I am using the setting "tab_height_tall": true in my personal preferences if that helps.

In the meantime I'll see about tweaking the new tabs so all elements balance vertically. But I do like the gap at the top of the active tab.

To use the older version, remove the Package Control version of Gravity. Then download the 2.1.4 tag and manually add it to your packages directory. https://github.com/frankyonnetti/gravity-sublime-theme/tree/2.1.4

gobijan commented 9 years ago

Hey Frank,

the new tabs really look better with "tab_height_tall": true :+1: Would it be possible to make the old tab style default if "tab_height_tall" : false ?

Cheers Bijan

gobijan commented 9 years ago

Now I know why the new tabs feel stranger to me than the old ones: they are farer away from apples own UI. Safari and Finder are a good example how apple designs tabs. The old style tabs were more close to the apple standard ui and therefore felt more native than the new ones here.

But this is just my opinion and this is your theme and of course you are in control of the design etc.

Just thought that if you want to position Gravity more or less as the default sublime ui for osx > 10.9 (everything below the soda theme is default) then it would make sense to keep closer to the original apple ui.

Let me know what you think :)

frankyonnetti commented 9 years ago

Hey @tschundeee I removed the visual gab above the active tab in 2.5.1. You're right, that looks better :-)

gobijan commented 9 years ago

I thought of adding a theme variant that has the new osx tabs recreated? I mean making the tabs behave exactly like the ones in Safari, Xcode or Finder. The close icon needs to sit on the left side and is hidden until mouse is hovered over the tab. Is this possible or is Sublime only showing the tab close button on the right?

frankyonnetti commented 9 years ago

I know you can hide the close icon, but I don't think you can move it to the left side of the tab. To see if you can, try to find a ST theme that has a close button on the left and review it's code.