One Dark: missing all punctuation.* scopes

frankyonnetti / gravity-sublime-theme

A Sublime Text theme that feels right at home on macOS

https://frankyonnetti.github.io/gravity-sublime-theme/

396 stars 26 forks source link

One Dark: missing all punctuation.* scopes #65

Closed rwols closed 3 years ago

rwols commented 3 years ago

I like this color scheme. Thanks for your work.

However:

variable.parameter has the same color as variable.function (both red). It would be nice if variable.parameter had a different color as function arguments are definitely a different concept than callables.
I'm missing punctuation scopes like punctuation.section, punctuation.group, punctuation.accessor, punctuation.definition.variable and punctuation.definition.string.

frankyonnetti commented 3 years ago

Hi @rwols Honestly that file is so old (XML) it could use a rebuild in the new way for writing schemes (JSON). Which I hope to do some day soon 🤷‍♂️. But if you would rather have it sooner, do you mind trying to fix it and create a pull request?

rwols commented 3 years ago

I'm not sure why this got closed. punctuation scopes are still missing.

rwols commented 3 years ago

By the way apologies in advance if I come across as too demanding and/or brief but I'm just documenting some shortcomings and overall really like the color palette. I don't have much more free time.

frankyonnetti commented 3 years ago

Hi @rwols sorry for taking so long to get to you. I spent more time on this and have come to the conclusion that I don't know enough about C++ to make good judgements on a color scheme that supports it.

This leaves us with two options:

You can try to fix the scheme when you have time and provide a pull request with the fixes.
Try out One Half Color Schemes package. I tried it and it may be worth you trying it as well.

Sorry I couldn't be more helpful.

rwols commented 3 years ago

Hi Frank, not a problem. I'll see what I can do about the selectors. Just covering all scopes from the "minimal scope coverage" here should work for all languages (not just C++).

frankyonnetti commented 3 years ago

Thanks @rwols !! All 3 PRs merged and pushed. Should show in Package Control within the hour as 4.0.2