search

franmomu / silex-pagerfanta-provider

Pagerfanta Silex Provider
14 stars 11 forks source link

Silex 1.1 update #3

Closed joshuaadickerson closed 10 years ago

joshuaadickerson commented 10 years ago

I can't upgrade Silex to 1.1 because of the dependency that franmomu/silex-pagerfanta-provider work with Silex 1.0

joshuaadickerson commented 10 years ago

If anyone else faces this issue, I just added "silex/silex": "1.1.1 as 1.0" in my composer.json file to get around this. Pagerfanta works with Silex 1.1

franmomu commented 10 years ago

Hi Joshua, thanks for reporting this, I guess this is solved with that commit, if not, let me know.

joshuaadickerson commented 10 years ago

Yeah, that solved it. I was just about to send a PR but that's easier. Thanks... and thanks for the service provider.

sfblaauw commented 10 years ago

Hi @franmomu. I don´t think what @joshuaadickerson says is the best way to make Pagerfanta work with Silex 1.1 because it can may cause errors with other services, in my case with umpirsky/i18n-routing-service-provider. I just make a fork and I change composer.json to "silex/silex": ">=1.0" and works with "silex/silex": "~1.1".

joshuaadickerson commented 10 years ago

He updated the dependency. No need to alias it anymore.

sfblaauw commented 10 years ago

Sorry you are right, I make a mistake, I didn't add the dependencies.