search

franrasl / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Patch: Update Freebase suggest widget #628

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The current suggest widget being used in Refine uses deprecated and one-off 
hack APIs which will be offline soon. This patch updates refine to use a new 
version of the suggest widget that uses the new Freebase APIs.

The new APIs however require an API key so I am adding a default API key with a 
new option in the freebase dropdown to set a custom API key.

See http://wiki.freebase.com/wiki/Freebase_Suggest

Original issue reported on code.google.com by s...@google.com on 3 Oct 2012 at 9:18

GoogleCodeExporter commented 8 years ago 
This needs to be backward compatible with custom suggest services. I have 
deleted the patch for now, I'll upload a new one when I have that working.

Original comment by s...@google.com on 3 Oct 2012 at 10:33

GoogleCodeExporter commented 8 years ago 
Ok, here's the patch file. The suggest widget is now backwards compatible with 
custom suggest services that emulate the old suggest API.

Original comment by s...@google.com on 8 Oct 2012 at 8:53

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for the patch.  Is this stock Freebase Suggest 4.0 as served from 
gstatic.com or has it been modified in some way?

It looks like we're currently running something 1.2.1 based which is pretty out 
of date considering how long 3.1 was available before 4.0.

Original comment by tfmorris on 8 Oct 2012 at 10:44

GoogleCodeExporter commented 8 years ago 
It is the stock suggest as served from the links below, no modifications 
whatsoever. All the customization is done in custom-suggest.js

https://www.gstatic.com/freebase/suggest/4_0/suggest.min.css
https://www.gstatic.com/freebase/suggest/4_0/suggest.min.js

Original comment by s...@google.com on 8 Oct 2012 at 10:57

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 12 Oct 2012 at 1:29

GoogleCodeExporter commented 8 years ago 
It appears that the new version of the Suggest widget no longer returns 
Freebase object types for matches which we're currently referencing.  

http://code.google.com/p/google-refine/source/browse/trunk/main/webapp/modules/c
ore/scripts/views/data-table/cell-ui.js#333

I'll need to dig further to see if we actually use this information.

Has this patch been deployed internally at Google?

Original comment by tfmorris on 12 Oct 2012 at 5:06

GoogleCodeExporter commented 8 years ago 
Fixed in r2575.  Thanks for the patch!

The last remaining problem was an incompatible change in the returned data from 
Suggest.  They changed "n:type" to "notable" (and "r:score" to "score", but we 
don't use that).

Original comment by tfmorris on 12 Oct 2012 at 6:53

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 12 Oct 2012 at 6:54

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 12 Oct 2012 at 7:15