search

frantjc / sequence

MIT License
0 stars 0 forks source link

let gRPC client pass more parameters to services #40

Closed frantjc closed 2 years ago

frantjc commented 2 years ago

e.g. the RunStep, RunJob, RunWorkflow endpoints should accept

verbose  bool // whether or not to log debug stuff
github   stuff // current context from git repository
// probably much more

the latter is a pretty major bug atm as the server looks in its own path to find the git repo which won't work if we are on a remote machine

frantjc commented 2 years ago

started in https://github.com/frantjc/sequence/pull/41

frantjc commented 2 years ago

update: server now accepts a

var repository string

which it uses to get GitHub context from and lookup config with. Eventually the former will need to be offloaded onto the client but this works for now while everything is running on the same machine

...unless the repository string is a URL, in which case the server can potentially get the GitHub context remotely. Not sure about this, though, as, off the top of my head, the server wouldn't have access to what branch the client is on