franzaps / zapthreads

The Unlicense
33 stars 8 forks source link

Add upvotes/downvotes #49

Open alopatindev opened 4 months ago

alopatindev commented 4 months ago

I'm not sure whether you're interested in this feature, but anyway, this adds upvotes/likes (+ reactions) and downvotes/dislikes (- reactions). Other reactions are ignored in the vote rating (because considering states like - and at the same time 💩 is a bit complicated).

If any user made several votes to a single message—all of the votes but the newest one will be ignored.

I didn't test it with the relays that don't support publishing reactions from free accounts.

Reactions are sent concurrently Promise.allSettled to the relays (but perhaps they should be sent the same way as comments publishing is done right now).

I didn't manage to make markup properly.

Feel free to make any changes if you find this PR valuable for merging.

franzaps commented 3 months ago

@alopatindev thank you for this! I have very little time at the moment to review it, but I'll come back to it. I see you keep pushing commits, let me know when you think it's done

alopatindev commented 3 months ago

Awesome! It's done.

franzaps commented 3 months ago

Why do you keep force pushing?

alopatindev commented 3 months ago

That was a forgotten minor fix. I'm not going to force-push anything to this branch anymore, sorry if it's annoying or something.

franzaps commented 3 months ago

It's okay, I keep getting notifications but I asked because I didn't understand. When I click I see no changes in file changes and wondered why force push

alopatindev commented 3 months ago

I force-push to make history cleaner, however, not sure whether it's convenient to use, but GitHub shows diffs with Compare button for each force-push, like if they were normal commits. 1