franzbecker / gradle-lombok

Gradle plugin for Lombok support
Apache License 2.0
182 stars 22 forks source link

Fixed issue #38 #40

Closed dialogbox closed 6 years ago

dialogbox commented 6 years ago

Fixed issue #38

I'm not sure about second item but I removed these because these were unnecessary in my test. Please add them back if you think we need to keep them.

I've tested them on gradle 4.5, 4.6 with IntelliJ idea CE 2018.1.

codecov-io commented 6 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
- Coverage      98.7%   98.68%   -0.02%     
  Complexity       22       22              
============================================
  Files             5        5              
  Lines            77       76       -1     
  Branches          7        7              
============================================
- Hits             76       75       -1     
  Partials          1        1
Impacted Files Coverage Δ Complexity Δ
...y/io/franzbecker/gradle/lombok/LombokPlugin.groovy 96.29% <100%> (-0.14%) 6 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d8a45e...2290eee. Read the comment docs.

franzbecker commented 6 years ago

It's still kind of a hack since it should not be an implementation dependency (only needed during annotation processing), but sadly I don't have time to look into some more.