RFE: Expose lombok dependency coordinates as an option

mmoayyed commented 6 years ago

Today, the plugin here adds the lombok dependency using its own coordinates:

        project.afterEvaluate {
            project.dependencies.add(
                    LOMBOK_CONFIGURATION_NAME,
                    "org.projectlombok:lombok:${project.lombok.version}",
                    {
                        transitive = false
                    }
            )
        }

Could I submit a pull request to turn the hard-coded coordinates into one that is defined by an option, and that the option has the current coordinates as defaults? The idea would be to expose the option inside LombokPluginExtension and then add it as it's normally done today.

I am in the process of experimenting with lombok in order to write a few custom extensions and the easiest way to do this would be to fork lombok (given there is no official extension mechanism AFAIK). With a forked lombok repository, I'd like to be able to use that fork with the plugin under my own coordinates. If the proposed option sounds good to you, I'd be happy to close this issue and follow-up with a pull request to get this done.

franzbecker commented 6 years ago

Sure please go ahead 👍

franzbecker commented 6 years ago

Please note that I'm refactoring the way the dependency is added, see https://github.com/franzbecker/gradle-lombok/pull/43

mmoayyed commented 6 years ago

Wonderful. I'll proceed with the changes and pull request shortly. Thank you.

Closing this for now.

franzbecker / gradle-lombok

RFE: Expose lombok dependency coordinates as an option #41