Closed mmoayyed closed 6 years ago
Merging #44 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 98.52% 98.52%
Complexity 21 21
=========================================
Files 5 5
Lines 68 68
Branches 7 7
=========================================
Hits 67 67
Partials 1 1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...y/io/franzbecker/gradle/lombok/LombokPlugin.groovy | 94.73% <ø> (ø) |
5 <0> (ø) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 72616b3...2def4b9. Read the comment docs.
Sure. I added a new class with invalid coordinates to verify build failures. I mostly wanted to avoid modifying the buildFile shared by other tests to minimize impact, but I dont exactly an expert on Spock; if there is a better way to do this, please let me know and I'd be happy to massage the config.
Also fixed a few typos in other test classes.
Thank you for the review!
@mmoayyed it looks like the build is still failing :-/
Sorry about the delay this one. I have backed off of this change for now. My original intention for doing this was to experiment with custom lombok extensions whereby the lombok project would be forked. I have since realized that the task is simply folly and not worth the time, and so I dont plan to pursue this.
Thank you for your time, as always. If you wish to continue to working on this, please do or else, feel free to close this pull request.
Per earlier discussions on #41