search

franzejr / best-ruby

Ruby Tricks, Idiomatic Ruby, Refactoring and Best Practices
http://franzejr.github.io/best-ruby/
2.39k stars 219 forks source link

Add new categories and interesting things #73

Closed DouglasAllen closed 7 years ago

DouglasAllen commented 7 years ago

best-ruby/idiomatic_ruby/collect_vs_select.md see the diff commits.

franzejr commented 7 years ago

@DouglasAllen, your idea is to add new categories?

franzejr commented 7 years ago

Some comments:

  1. If you would like to add a new category, please create an issue and then we will talk about this new category. So far, we have some categories and what we would like is to create more content on those categories and not create new categories with just 1 or 2 links/interesting thing inside.
  2. Your PR adds some new categories and it's not well-organised, with this, it's hard to review the entire PR.
  3. We're not using .rb files, look at the others sections.

Also, this repo is meant to be primarily a discussion, not a lot of ruby files without commentary.