search

franzenzenhofer / f19n-obtrusive-livetest

A sandboxed, extendable testing chrome extension and framework! It runs pre-defined and custom tests on each page that you visit.
https://chrome.google.com/webstore/detail/f19n-obstrusive-live-test/jbnaibigcohjfefpfocphcjeliohhold?hl=en
55 stars 1 forks source link

Edit rule overlay should be as big as possible (nearly whole viewport) #18

Closed neuling closed 8 years ago

hg-lr commented 8 years ago

all styles on the modal and the editor are inlined styles, but we don't know where they are set

in the current version added styles on .ReactModalOverlay, .ReactModalContent and .ace_editor which do take effect but it's not the best solution for sure (overriding the style attribute with !important)

where and how is the modal configured?

f19n_-_rules rules_sass_ _f19n-livetest

neuling commented 8 years ago

i am trying to find a cleaner way but atm the only way to style the modal is either overwrite the styles with !important from your css OR set the styles from the javascript/react code.

see here: https://github.com/franzenzenhofer/f19n-livetest-chrome-extension/blob/master/src/javascripts/components/Rules/Rules.js#L72

franzenzenhofer commented 8 years ago

done, closed