rule configuration

[franzenzenhofer]

rule configuration

%GoogleApiKey%

leads to

GoogleApiKey: [ ]

rules that need a rule configuration are default disabled

[franzenzenhofer]

MVP prio low

but

Feature prio high

[neuling]

i did a first quick implementation of this feature. you need to checkout the branch configurable-rules to test it.

here is a short demonstration: http://recordit.co/7uh5MzYIvQ

looking forward to your feedback. i think its pretty sweet but surely needs to be tested before we merge it into production.

[franzenzenhofer]

cool, will test tonight

On Wed, Mar 22, 2017 at 1:26 PM, Moritz Kobrna notifications@github.com wrote:

i did a first quick implementation of this feature. you need to checkout the branch configurable-rules to test it.

here is a short demonstration: http://recordit.co/7uh5MzYIvQ

looking forward to your feedback. i think its pretty sweet but surely needs to be tested before we merge it into production.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/franzenzenhofer/f19n-livetest-chrome-extension/issues/50#issuecomment-288383155, or mute the thread https://github.com/notifications/unsubscribe-auth/AATudjhQyExh0FU_Yd0pAHHlnXnk5xv9ks5roRNygaJpZM4MZQH3 .

[franzenzenhofer]

could not get it to work (click on rule does now show overlay)

but if it works, go ahead

[neuling]

k i will merge this branch into the master as soon as we have a solution for all the other issues. don't want to implement to much at once.

[neuling]

merged into master!