search

franzenzenhofer / f19n-obtrusive-livetest

A sandboxed, extendable testing chrome extension and framework! It runs pre-defined and custom tests on each page that you visit.
https://chrome.google.com/webstore/detail/f19n-obstrusive-live-test/jbnaibigcohjfefpfocphcjeliohhold?hl=en
55 stars 1 forks source link

filtering should not resize panel #54

Closed franzenzenhofer closed 7 years ago

franzenzenhofer commented 7 years ago

is: filtering (lable, type) resizes the pane should: filtering does not resize panel (as async rules might get missed)

franzenzenhofer commented 7 years ago

@neuling MVP prio HIGH (as it is a behaviour that we have, but does not work as intended)

neuling commented 7 years ago

hmm not sure if the resizing is the actual problem. it seems like that when i filter for something all Pending results will be removed and reevaluated after some time? i probably need to dig into your async rules implementation to fix this problem.

pls give me some more input on this issue before i start investigating in the wrong direction.

franzenzenhofer commented 7 years ago

hi, i would really just evaluate the resize behaviour (other you found an issue I don't see)

mar-22-2017 12-29-08

neuling commented 7 years ago

oh, got it. interesting … can't reproduce this error. maybe #51 fixed this error. pls pull, rebuild, reload and test if it still happen.

franzenzenhofer commented 7 years ago

is fixed

On Wed, Mar 22, 2017 at 12:48 PM, Moritz Kobrna notifications@github.com wrote:

oh, got it. interesting … can't reproduce this error. maybe #51 https://github.com/franzenzenhofer/f19n-livetest-chrome-extension/issues/51 fixed this error to. pls pull, rebuild, reload and test if it still happen.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/franzenzenhofer/f19n-livetest-chrome-extension/issues/54#issuecomment-288375234, or mute the thread https://github.com/notifications/unsubscribe-auth/AATudlXMQVC7V1WHCF9LbqSkQ3Ura3heks5roQqggaJpZM4Mf8-E .