adding rules broken

[franzenzenhofer]

whenever I now edit a default rule, after the edit the default rule vanishes - and the custom rules get forgotten

[franzenzenhofer]

hi, could recreate the

A) "custom rules deleted with default rules update" issue

but not the B) "default rules vanishes after update" issue (but it was there....)

ad A)

create a blank default rule (no text in file)

add some custom rules

update default rule (as some acutal JS)

-> custom rules are gone

ad B) could not repleciate but please investigate

MVP critical bug

[franzenzenhofer]

hmmm, i just created this default rule and whatever I do now (even a blank install) this rule does not show up in the setting panel (and does not get executed) https://github.com/franzenzenhofer/f19n-livetest-chrome-extension/blob/master/src/public/default-rules/static-idle-head-title-compare.js

[neuling]

oh noe. will look into it now.

[neuling]

removing custom rules on default-rules changes is fixed.

[neuling]

the other problem (not being able to add new rules) should also be fixed. we hit the max quota on the storage. i added the permissions for "unlimitedStorage" to the manifest.

https://developer.chrome.com/extensions/storage#property-local

[franzenzenhofer]

hi @neuling thx

but deinstalled extension built the extension again quit the browser started the browser again added extension again https://github.com/franzenzenhofer/f19n-livetest-chrome-extension/blob/master/src/public/default-rules/static-idle-head-title-compare.js still does not show up?

[neuling]

hmm. strange. will check it again and fix it asap.

[neuling]

sorry @franzenzenhofer. i found two additional bugs. should finally be fixed now. hopefully. let me know if everything works.