Remove chrome.loadTimes() and replace with standardized APIs

franzenzenhofer / f19n-obtrusive-livetest

A sandboxed, extendable testing chrome extension and framework! It runs pre-defined and custom tests on each page that you visit.

https://chrome.google.com/webstore/detail/f19n-obstrusive-live-test/jbnaibigcohjfefpfocphcjeliohhold?hl=en

55 stars 1 forks source link

Remove chrome.loadTimes() and replace with standardized APIs #83

Closed neuling closed 5 years ago

neuling commented 5 years ago

We should remove chrome.loadTimes() since its deprecated and throws extension warnings:

screenshot 2019-03-01 11 05 49

What todo:

[ ] Replace the usage of loadTimes in all rules with standardized APIs (https://developers.google.com/web/updates/2017/12/chrome-loadtimes-deprecated)
[ ] Remove chrome.loadTimes() from the core https://github.com/franzenzenhofer/f19n-obtrusive-livetest/blob/f6a9dc0cc65848030a06537224c0c26888634e53/src/javascripts/document_idle.js#L1

franzenzenhofer commented 5 years ago

please (I see this as a nearly realted to security update task, as this will break the application in the future for sure)

neuling commented 5 years ago

I removed the deprecated loadTimes API from our core. To be downward compatibility for users that might use getChromeLoadTimes() in their custom rules, calling this function will throw an error (see screenshot).

screenshot 2019-03-06 13 34 52

Next step is to fix both of the core rules to use standardized APIs.

franzenzenhofer commented 5 years ago

ich kümmer mich drum

neuling commented 5 years ago

Ok, ich würde den Branch update-and-fix-security-notifications-gh79 gerne in den master mergen damit ich die intakte build-pipeline für die restlichen Issues habe.

Passt das? Du fixt die zwei Rules dann entweder im master oder machst dir einen eigenen Branch dafür.

franzenzenhofer commented 5 years ago

hab was gepusht ad webperformacne api, bitte mergen in master

neuling commented 5 years ago

Done!