search

franzheidl / atom-applescript

Applescript language support for Atom
6 stars 4 forks source link

Add package-setting to control auto-compilation #9

Closed Alhadis closed 8 years ago

Alhadis commented 8 years ago

I can't speak for all users, but I find it incredibly disconcerting to see files being compiled without my consent (and initially, without my knowledge). I had to save this file using Emacs instead of Atom just to avoid committing a binary file to my project's repository. :p

This PR places the auto-compilation feature under the control of a new package setting, which is on by default (so there's no change of functionality being forced on users). It looks like this:

Figure 1

I also added two commands to manually decompile/recompile AppleScripts, although they're not assigned any keymappings by default. Users who prefer the autocompilation feature be disabled are free to map them to whatever shortcuts they please (or run the commands through the Command Palette).

I've only performed cursory testing: you might want to test it more thoroughly in case I've missed anything. Should be fine, though. =)

Alhadis commented 8 years ago

/cc @franzheidl

franzheidl commented 8 years ago

Hi, many thanks for your PR!

Problem is I currently hardly have the bandwidth to do some thorough testing, so if you performed a bit more testing I’d take it on your word and merge.

Having said that, would you be interested in taking over maintaining this package?

In any event, your contribution is much appreciated, thanks! 👍

Alhadis commented 8 years ago

Ah I'm afraid I'm the wrong person to ask when it comes to AppleScript... I've had to write one or two little things in it, but my knowledge and interest in the language is extremely minimal. :(

As for the testing, well, I probably made it sound lax in hindsight. The package's setting is working fine.

franzheidl commented 8 years ago

Ok, fair enough :)

I'm away over the weekend until next Wed, I'll merge when back. Thanks again!

Alhadis commented 8 years ago

Bitte schön, buddy. =)

Alhadis commented 3 years ago

Having said that, would you be interested in taking over maintaining this package?

@franzheidl Changed my mind, pass it over. 😜