search

franzholz / static_info_tables_de

German language pack for the TYPO3 Extension static_info_tables
5 stars 17 forks source link

Why is jambagecom/addons-em a requirement of static_info_tables_de? #22

Open josefglatz opened 2 years ago

josefglatz commented 2 years ago

I can't find any code which relies on the mentioned extension.

franzholz commented 2 years ago

TYPO3 is not able to handle changes in the file ext_tables_static+adt.sql. The Extension Manager update function did not work since some years. This has already been discussed on Slack.

josefglatz commented 1 year ago

Ah OK, I see. So it is an improvement for all static imports.

Am 23.03.2022 um 11:07 schrieb Franz Holzinger @.***>:

TYPO3 is not able to handle changes in the file ext_tables_static+adt.sql. The Extension Manager update function did not work since some years. This has already been discussed on Slack.

— Reply to this email directly, view it on GitHub https://github.com/franzholz/static_info_tables_de/issues/22#issuecomment-1076181420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAV2T5FJNTTS6XAND4ELUB3VBLUOVANCNFSM5RNDWSGQ. You are receiving this because you authored the thread.

IchHabRecht commented 1 year ago

Hi @franzholz,

as I'm not part of the slack communication, is there any way to link to it or quote it here? That the update function for ext_tables_static+adt.sql doesn't work is new to me. I use it in TYPO3 10.4 and 11.5 by myself in different projects.

franzholz commented 1 year ago

What is the question?

IchHabRecht commented 1 year ago

@franzholz the questions are:

franzholz commented 1 year ago

Here is the discussion from Slack 14th January 2022:

_Franz Holzinger 17:22: I need to fix the issue in which the updates of the static_info_tables language extensions are not any more executed. If I have activated the extension static_info_tables_de and then I modify the file ext_tables_static+adt.sql for example with this: UPDATE static_countries SET cn_short_de='CHANGED Österreich Mountain Country' WHERE cn_iso_2='AT'; Then I click on the icon The static database data has been changed. You should re-import the data. And nothing happens. This is because the SchemaMigrator.php function importStaticData only deals with IMPORT statements. Why are the UPDATE lines ignored? Is this not any more then intended behaviour to execute all updates from the file ext_tables_static+adt.sql as in the former versions of TYPO3 and static_info_tables? Must I write an UpgradeWizard for this file? https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/ApiOverview/UpdateWizards/Creation.html

Mathias Brodala

This file did never support updates, you are always required to drop and re-import everything. [17:25 Uhr] See https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/FilesAndLocations/Index.html#ext-tables-static-adt-sql [17:26 Uhr] If you need updates, you should add a TYPO3 upgrade wizard or suggest a migration tool.

Franz Holzinger [17:33 Uhr]The ext_tables_static+adt.sql in static_info_tables_de has always contained only UPDATE SQL commands. The TYPO3 backend icon is already there. So this should be usable also for static_info_tables_de . (bearbeitet)

Mathias Brodala What TYPO3 version did you test with? Did this work in older versions?

Franz Holzinger [17:49 Uhr] In former versions of TYPO3 (3.6 - 9.5) the file class.ext_update.php did the job to import the changes of the the file ext_tables_static+adt.sql . Yes, it did always work in this way.

Simon Gilli [17:51 Uhr] Should still work with 10.4 but not with 11.5 anymore see https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.0/Breaking-93083-Classext_updatephpHandlingRemoved.html

Chris Wolff [20:13 Uhr] Static info table always used some "hacks" to extend the main tables in the language versions

David Bruchmann [20:32 Uhr] nowadays we use different hacks_

franzholz commented 1 year ago

It has not been possible to edit the SQL file manually and then use the Extension Manager to update the database for only the language SQL. A new execution of the SQL file from static_info_tables has deleted all the languages. But only the changes language fields must be updated instead. This has been fixed by the helper extension addons_em.