franzinc / agraph-python

AllegroGraph Python client
https://franz.com/agraph
MIT License
40 stars 12 forks source link

ag_connect does not correctly handle the protocol parameter #16

Closed mdw00d closed 3 years ago

mdw00d commented 3 years ago

The protocol parameter is not correctly handled; this is due to a typo in the following line of code:

https://github.com/franzinc/agraph-python/blob/db2b155f43e5af16851117b88baf90ff3c297608/src/franz/openrdf/connect.py#L102

which says:

 server = AllegroGraphServer(host=host, port=port, protcol=protocol,

Note the misspelling "protcol=protocol".

The work-around for this is to use the full URI as the host, rather than trying to pass in host, port and protocol separately.

jkftiger348 commented 3 years ago

Thank you for pointing this out. We'll make a new release soon including this fix.

jkftiger348 commented 3 years ago

101.0.8 with the fix is now in github. It hasn't been uploaded to PyPi or conda yet.