franzinc / aserve

AllegroServe, a web server written in Common Lisp
http://www.franz.com/support/documentation/current/doc/aserve/aserve.html
Other
190 stars 30 forks source link

Old documentation for SSL/TLS #12

Open kmcgivney opened 3 years ago

kmcgivney commented 3 years ago

In the allegroserve documentation on SSL/TLS, https://github.com/franzinc/aserve/blob/master/doc/aserve.md#ssltls, there's some very old information about TLS (old with respect to TLS and with respect to aserve's support for TLS). In that section, it links to https://franz.com/support/documentation/current/doc/operators/socket/make-ssl-server-stream.htm, however that is also out of date, claiming it only goes up to :tlsv1. I believe that the best documentation you have on this is over here: https://franz.com/support/documentation/10.1/doc/operators/socket/make-ssl-client-context.htm which includes keywords up through :tlsv1.2.

I believe we should remove the outdated discussion of TLS and either explain the argument options here, or link to a page that does that. Thanks.

franzinc commented 3 years ago

Thanks. We will look into it.

jkftiger348 commented 2 years ago

We've uploaded an update to the documentation for net.aserve:start to include the ssl-args argument that has been present for a while but not documented. With the ssl-args argument you can pass the arguments you want given to make-ssl-server-stream (https://franz.com/support/documentation/current/doc/operators/socket/make-ssl-server-stream.htm) to control the ssl stream created. This gives you complete control of the stream created based on the capabilities of the underlying lisp.

kmcgivney commented 2 years ago

Thanks @jkftiger348 . I was already using that on the down-low, to specify things like ciphers and certificate. But it's good that it's documented now. This issue is still open because the file aserve.md#ssltls is out of date with regards to supported SSL/TLS versions. I'm sure there's a way to reword it to account for this change.