search

franzliedke / studio

A workbench for developing Composer packages.
MIT License
1.14k stars 73 forks source link

Issue with library versions not being detected. #58

Closed jonnywilliamson closed 6 years ago

jonnywilliamson commented 8 years ago

I have been asked to leave this issue here, but I'm not sure I'll get the wording correct.

Basically, I attempted to use studio to clone a github library like this:

studio create telegram-bot-sdk --git https://github.com/irazasyed/telegram-bot-sdk

Then I went to my project root and attempted to require the library:

composer require irazasyed/telegram-bot-sdk expecting studio to create a symlink to the local copy. That didn't happen and all I got was the library saved in the vendor folder as normal.

Having spoken with @franzliedke, he suggested to try using the dev-master version for my composer require which I did:

composer require irazasyed/telegram-bot-sdk:dev-master and suddenly everything worked* fine.

I hope this helps someone else.

*Well not actually the first time. There was a problem creating the symlink but that was fixed by running vagrant as admin.

TiGR commented 8 years ago

@franzliedke this is still not working. And as regarding your question in #55 - nope, adding new commit does not work. Even if you add new tag - it still does not work.

If you have version tag specification in composer require - studio just does not kick in. It works if it is dev-master, that is in source mode. Could this be fixed, please?

rask commented 8 years ago

Would this require overwriting the Composer LibraryInstaller to bypass version constraint checks or is that logic too deep in the Composer core for a plugin to override properly?

piperone commented 7 years ago

I echo this issue with an added caveat. Since my packages are somewhat interdependent, I have to update all composer.json-files involved and require "dev-develop" for studio to work. It does become a bit of a hassle.

rask commented 7 years ago

@fredrkr same here, I create temporary branches where I flip from dev-master to dev-develop in order to keep libraries in development state.

franzliedke commented 6 years ago

Please try out the newly released 0.14.0-beta1 version. I am hoping this issue will be gone.

(Note that you will have to run composer update and composer dump-autoload for the installation of any package.)

franzliedke commented 6 years ago

Cannot reproduce the problem with the latest beta version, so I am closing this. :smiley: