search

franzliedke / studio

A workbench for developing Composer packages.
MIT License
1.14k stars 73 forks source link

studio create -> Namespace contains / (forward slash) #70

Closed seb-ster closed 8 years ago

seb-ster commented 8 years ago

Great Package! But after following the initial tutorial from the README, the package namespace (Example.php) contains / (forward slahes) as separator. Also the autoload_static.php arrays contain forward slashes. After i fixed this, my package worked.

Studio 0.11.1 Windows 10 Apache 2.4.23 PHP 5.6.25 Composer 1.2.2

seb-ster commented 8 years ago

Tried it again with a new Package. It appears that i made a Typo on the first one. studio create worked correct on the second package.

But it might be a nice feature to atomatically correct forward slahes in the namespace.

tomicakorac commented 8 years ago

@seb-ster can you please close your issue if it's been resolved?

seb-ster commented 8 years ago

I would like to keep it open as a request for a feature. Or as an issue of validating user input?

On 25 Nov 2016 13:30, "Томица Кораћ" notifications@github.com wrote:

@seb-ster https://github.com/seb-ster can you please close your issue if it's been resolved?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/franzliedke/studio/issues/70#issuecomment-262948038, or mute the thread https://github.com/notifications/unsubscribe-auth/AP5r9gfRnXSFi7JHg85uOyIMtbqwdGM4ks5rBtTQgaJpZM4K6VV9 .

franzliedke commented 8 years ago

Released as part of version 0.11.2.

I guess we could improve the regex that validates namespace names - if any of you want to send a pull request, that would be very cool. :)