search

franzliedke / studio

A workbench for developing Composer packages.
MIT License
1.14k stars 73 forks source link

Allow Symfony 5.0 #98

Closed emodric closed 4 years ago

franzliedke commented 4 years ago

Thanks a lot!

simonberger commented 4 years ago

@emodric @franzliedke It seems not to be compatible to symfony 5 though

PHP Fatal error: Uncaught TypeError: Argument 1 passed to Symfony\Component\Process\Process::__construct() must be of the type array, string given

https://github.com/symfony/symfony/blob/5.0/UPGRADE-5.0.md#process

emodric commented 4 years ago

Doh! When I tested the package, I somehow didn't notice that I was using Symfony 4.4 instead of 5.0, so there were no issues :/

What would be the best way to fix this? Some form of version detection? The new syntax was introduced in Symfony 3.3 I believe.

franzliedke commented 3 years ago

@emodric @simonberger That problem only occurred within studio create, right? That now works with Symfony 5 after this commit.

This has been relased in version 0.15.0.

simonberger commented 3 years ago

I absolutely don't remember what I did back then 😎

emodric commented 3 years ago

I don't really remember either 😆